[PATCH] D81358: [PowerPC] Implement probing for dynamic stack allocation

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 21 21:09:51 PDT 2020


lkail added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11613
+        .getValueAsString()
+        .getAsInteger(0, StackProbeSize);
+  // FIXME: We currently lack facility to materialize constants at MIR level,
----------------
steven.zhang wrote:
> Can we make it as unsigned integer ?
Looks `getAsInteger` already does it.
```
    template <typename T>
    std::enable_if_t<!std::numeric_limits<T>::is_signed, bool>
    getAsInteger(unsigned Radix, T &Result) const;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81358/new/

https://reviews.llvm.org/D81358





More information about the llvm-commits mailing list