[PATCH] D81358: [PowerPC] Implement probing for dynamic stack allocation

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang added a comment.

Some minor comments.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11613
+        .getValueAsString()
+        .getAsInteger(0, StackProbeSize);
+  // FIXME: We currently lack facility to materialize constants at MIR level,
----------------
Can we make it as unsigned integer ?


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11642
+  MachineBasicBlock *BlockMBB = MF->CreateMachineBasicBlock(LLVM_BB);
+
+  MachineFunction::iterator MBBIter = ++MBB->getIterator();
----------------
Adding some comments to indicate what the CFG looks like will make the code more clear.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11696
+    Register CmpResult = MRI.createVirtualRegister(&PPC::CRRCRegClass);
+    BuildMI(TestMBB, DL, TII->get(isPPC64 ? PPC::CMPD : PPC::CMPW), CmpResult)
+        .addReg(SPReg)
----------------
Can we use the CTR loop ?


================
Comment at: llvm/test/CodeGen/PowerPC/stack-clash-dynamic-alloca.ll:3
+; RUN: llc -ppc-asm-full-reg-names -verify-machineinstrs \
+; RUN:   -mtriple=powerpc64le-linux-gnu < %s | FileCheck \
+; RUN:   -check-prefix=CHECK-LE %s
----------------
Check the run for pwr9


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81358/new/

https://reviews.llvm.org/D81358