[PATCH] D79962: Fix the verification of DIEs with DW_AT_ranges.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:416
+      // more dead stripped address ranges which tend to all be at the same
+      // address: 0 or -1.
+      if (auto PrevRange = RI.insert(Range)) {
----------------
jhenderson wrote:
> -1 probably should be -2 in this context, since -1 is for base address selection entries. In the Sony linker and the LLD patch, we use -2 for .debug_ranges and dead values (-1 is used elsewhere where it can be).
For .debug_ranges

* GNU ld: [1,1)
* gold and LLD before D81988: [addend0, addend1)   ( addend0 is very likely 0 )
* LLD since D81988: [-2,-2)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79962/new/

https://reviews.llvm.org/D79962