[PATCH] D79962: Fix the verification of DIEs with DW_AT_ranges.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 19 01:02:24 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one small comment.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:416
+      // more dead stripped address ranges which tend to all be at the same
+      // address: 0 or -1.
+      if (auto PrevRange = RI.insert(Range)) {
----------------
-1 probably should be -2 in this context, since -1 is for base address selection entries. In the Sony linker and the LLD patch, we use -2 for .debug_ranges and dead values (-1 is used elsewhere where it can be).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79962/new/

https://reviews.llvm.org/D79962





More information about the llvm-commits mailing list