[PATCH] D82017: [DebugInfo/DWARF] - Do not hang when CFI are truncated.

Thu Jun 18 01:35:59 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/test/DebugInfo/X86/eh-frame-truncated-cfi.s:4
+
+# RUN: llvm-mc -triple x86_64-unknown-linux %s -filetype=obj -o %t
+# RUN: not llvm-dwarfdump -debug-frame %t 2>&1 | FileCheck %s
----------------
MaskRay wrote:
> Drop `-unknown-linux`. This is a generic ELF behavior not specific to Linux.
You've added several new error cases, but only one new test case. You need one for each individual new error check, I think. It may be better to write the testing as unit tests. See similar work I've been doing recently for .debug_line.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82017/new/

https://reviews.llvm.org/D82017