[PATCH] D82017: [DebugInfo/DWARF] - Do not hang when CFI are truncated.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:80
+        addInstruction(Opcode, Data.getRelocatedAddress(
+                                   Offset, /*SectionIndex =*/nullptr, &Err));
         break;
----------------
clang-format may prefer `/*SectionIndex=*/nullptr`


================
Comment at: llvm/test/DebugInfo/X86/eh-frame-truncated-cfi.s:2
+## Check we report a proper error when the content of the .eh_frame section
+## is truncated so that the initial instructions are can't be read.
+
----------------
s/are //


================
Comment at: llvm/test/DebugInfo/X86/eh-frame-truncated-cfi.s:4
+
+# RUN: llvm-mc -triple x86_64-unknown-linux %s -filetype=obj -o %t
+# RUN: not llvm-dwarfdump -debug-frame %t 2>&1 | FileCheck %s
----------------
Drop `-unknown-linux`. This is a generic ELF behavior not specific to Linux.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82017/new/

https://reviews.llvm.org/D82017