[PATCH] D81841: AMDGPU: Don't use 16-bit FP inline constants in integer operands

Wed Jun 17 16:44:17 PDT 2020

arsenm closed this revision.
arsenm marked an inline comment as done.
arsenm added a comment.

5f5f566b265db00f577ead268400d99f34ba9cdd <https://reviews.llvm.org/rG5f5f566b265db00f577ead268400d99f34ba9cdd>

================
Comment at: llvm/test/MC/Disassembler/AMDGPU/literalv216_gfx10.txt:82

-# GFX10: v_pk_mad_i16 v5, 1.0, 2.0, 4.0  ; encoding: [0x05,0x40,0x00,0xcc,0xf2,0xe8,0xd9,0x1b]
+# GFX10: v_pk_mad_i16 v5, 0x3c00, 0x4000, 0x4400  ; encoding: [0x05,0x40,0x00,0xcc,0xff,0xfe,0xfd,0x1b,0x00,0x3c,0x00,0x00]
 0x05,0x40,0x00,0xcc,0xf2,0xe8,0xd9,0x1b
----------------
dp wrote:
> This and subsequent changes define special tests which check that disassembler is able to decode invalid instructions. Should they be separated from regular tests? Or have an appropriate comment?
I wasn't sure what to do here since we don't have an answer to perfect round trip disassembly

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81841/new/

https://reviews.llvm.org/D81841