[PATCH] D82034: [docs] Clarify semantics of ordered fadd/fmul reductions.
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 17 15:40:06 PDT 2020
aemerson marked 2 inline comments as done.
aemerson added inline comments.
================
Comment at: llvm/docs/LangRef.rst:15135
+the operation respects the associativity of a scalarized reduction. That is, the
+order begins with the start value, and performs an fadd operation with consecutively
+increasing vector element indices. See the following pseudocode:
----------------
spatel wrote:
> "That is, the operation begins with the start value and performs..." ?
Maybe "the reduction begins with" would be clearer.
================
Comment at: llvm/docs/LangRef.rst:15204-15205
reduction will not preserve the associativity of an equivalent scalarized
counterpart. Otherwise the reduction will be *ordered*, thus implying that
the operation respects the associativity of a scalarized reduction.
----------------
spatel wrote:
> Add the corresponding text/example for fmul too?
Will do.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82034/new/
https://reviews.llvm.org/D82034
More information about the llvm-commits
mailing list