[PATCH] D81908: [MIPS] Fix incorrect relocations of instruction

[hev via Phabricator via llvm-commits]

hev marked an inline comment as done.
hev added a comment.

Thanks for review.



================
Comment at: llvm/test/MC/Mips/reloc-implicit-constraints-error.s:10
+  ori  $4, $4, start            # CHECK: [[@LINE]]:{{[0-9]+}}: error: should use explicit constraints
+  ori  $4, $4, (start - .)      # CHECK: [[@LINE]]:{{[0-9]+}}: error: should use explicit constraints
+
----------------
MaskRay wrote:
> `ori  $4, $4, (start - .)` should probably be accepted. `start - .` computes to a representable constant.
The constant results of sub-expression may be overflow too. for implement, There is also no basic infrastructure for calculating sub-expressions. so, I prefer the explicit way for all cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81908/new/

https://reviews.llvm.org/D81908