[PATCH] D81764: [flang] Add the Mangler module to flang lowering

[Eric Schweitz via Phabricator via llvm-commits]

schweitz marked 2 inline comments as done.
schweitz added inline comments.


================
Comment at: flang/lib/Lower/Mangler.cpp:1
+//===-- Mangler.cpp -------------------------------------------------------===//
+//
----------------
kiranchandramohan wrote:
> Nit: Usually the path is also there. lib/Lower/Mangler.cpp
Lower uses a lot of the MLIR/LLVM conventions since it is "close to" MLIR.


================
Comment at: flang/lib/Lower/Mangler.cpp:66
+std::string
+Fortran::lower::mangle::mangleName(fir::NameUniquer &uniquer,
+                                   const Fortran::semantics::Symbol &symbol) {
----------------
kiranchandramohan wrote:
> Is the uniquer modified inside this function?
It's passed around a bit like an MLIRContext. The reference just means it can't be a null pointer. Again, lower follows the MLIR conventions, here with respect to `const`.

https://mlir.llvm.org/docs/Rationale/UsageOfConst/



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81764/new/

https://reviews.llvm.org/D81764