[PATCH] D81764: [flang] Add the Mangler module to flang lowering

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.


================
Comment at: flang/include/flang/Lower/Mangler.h:1
+//===-- Lower/Mangler.h -- name mangling ------------------------*- C++ -*-===//
+//
----------------
Nit: generally is like include/flang/Lower/Manger.h


================
Comment at: flang/lib/Lower/Mangler.cpp:1
+//===-- Mangler.cpp -------------------------------------------------------===//
+//
----------------
Nit: Usually the path is also there. lib/Lower/Mangler.cpp


================
Comment at: flang/lib/Lower/Mangler.cpp:66
+std::string
+Fortran::lower::mangle::mangleName(fir::NameUniquer &uniquer,
+                                   const Fortran::semantics::Symbol &symbol) {
----------------
Is the uniquer modified inside this function?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81764/new/

https://reviews.llvm.org/D81764