[PATCH] D81109: llvm-link: Add support for archive files as inputs.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

LGTM (after remaining minor inline comments)



================
Comment at: llvm/tools/llvm-link/llvm-link.cpp:14
 
+#include "llvm/Object/Archive.h"
 #include "llvm/ADT/STLExtras.h"
----------------
Includes are sorted alphabetically, clang format should do this for you (run `git clang-format HEAD~...HEAD` to format only your diff)


================
Comment at: llvm/tools/llvm-link/llvm-link.cpp:176
+      WithColor::error() << " loading memory for member '" << ChildName
+                         << "' of archive library failed'" << ArchiveName
+                         << "'\n";
----------------
Nit: you're missing a space between "failed" and `'`


================
Comment at: llvm/tools/llvm-link/llvm-link.cpp:187
+      WithColor::error() << "  member of archive is not a bitcode file: '"
+                         << ChildName << "'\n";
+      return nullptr;
----------------
Nit: in other places the error message include the Archive name, I don't know if it was intentional to omit it here.


================
Comment at: llvm/tools/llvm-link/llvm-link.cpp:196
+      WithColor::error() << " parsing member '" << ChildName
+                         << "' of archive library failed'" << ArchiveName
+                         << "'\n";
----------------
(Same missing space here)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81109/new/

https://reviews.llvm.org/D81109