[PATCH] D81109: llvm-link: Add support for archive files as inputs.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 11:32:59 PDT 2020


mehdi_amini added a comment.

In D81109#2089969 <https://reviews.llvm.org/D81109#2089969>, @gregrodgers wrote:

> LGTM, only one new auto in an existing code with 11 previous autos. Looks like consistent usage.


Some previous reviewers not catching deviation from the coding standard does not seem like a justification to continue this route, but rather an indication that the rest of the code could be updated. 
Also the sheer number of uses of `auto` does not say anything: it is all about *how* it is used.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81109/new/

https://reviews.llvm.org/D81109





More information about the llvm-commits mailing list