[PATCH] D81863: [gicombiner] Allow generated combiners to store additional members
Aditya Nandakumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 15 14:54:26 PDT 2020
aditya_nandakumar added inline comments.
================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerCombiner.cpp:298
public:
- AArch64GenPostLegalizerCombinerHelper Generated;
+ AArch64GenPostLegalizerCombinerHelperRuleConfig GeneratedRuleCfg;
----------------
These names are getting a bit too long. Can we come up with a better naming scheme for these?
================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PreLegalizerCombiner.cpp:77
MachineDominatorTree *MDT;
+ AArch64GenPreLegalizerCombinerHelperRuleConfig GeneratedRuleCfg;
----------------
Similar with how long this is?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81863/new/
https://reviews.llvm.org/D81863
More information about the llvm-commits
mailing list