[PATCH] D80855: [lld-macho] Support non-pcrel section relocs
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 15 13:14:23 PDT 2020
MaskRay accepted this revision.
MaskRay added a comment.
Thanks!
================
Comment at: lld/test/MachO/relocations.s:36
mov $1, %rdi # stdout
- leaq _str(%rip), %rsi
+ leaq _str(%rip), %rsi # This generates a pcrel symbol relocation
mov $21, %rdx # length of str
----------------
Rather than saying "This generates a pcrel symbol relocation",
it may be more helpful to just write the relocation type.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80855/new/
https://reviews.llvm.org/D80855
More information about the llvm-commits
mailing list