[PATCH] D80855: [lld-macho] Support non-pcrel section relocs

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/test/MachO/relocations.s:60
+## This generates a non-pcrel section relocation
+  .quad L_.str
----------------
int3 wrote:
> smeenai wrote:
> > Are you missing the corresponding CHECK for this? It would also be nice to add a test with a non-zero offset.
> > Are you missing the corresponding CHECK for this?
> 
> oh yeah good catch
> 
> > It would also be nice to add a test with a non-zero offset.
> 
> L._str is at a non-zero offset in its section, which I think is the important case to test, but yeah I guess it wouldn't hurt to add another reloc whose source is also at a non-zero offset
Ah, I'd missed that, but yeah, the second reloc doesn't hurt.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80855/new/

https://reviews.llvm.org/D80855