[PATCH] D81850: [AArch64][SVE] NFC: Choose consistent naming for predicated SDAG nodes

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 15 09:46:53 PDT 2020


sdesmalen created this revision.
sdesmalen added reviewers: paulwalker-arm, cameron.mcinally, eli.friedman, dancgr.
Herald added subscribers: danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett.
Herald added a reviewer: efriedma.
Herald added a project: LLVM.

This patch proposes a naming convention for operations that take
a general predicate (and are thus predicated) that specifies
what happens to the false lanes.

Currently the _PRED suffix is used, which doesn't really say much other
than that it takes a predicate. In some instances this means it has
merging predication and in other cases it means zeroing-predication.

This patch should clear up that confusion and also proposes a naming
convention for two other kinds of predication that are currently
not used yet; 'undef' (false lanes are explicitly left unspecified)
and 'passthru' (a passthru vector is explicitly merged into the false
lanes).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81850

Files:
  llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.h
  llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
  llvm/lib/Target/AArch64/SVEInstrFormats.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81850.270778.patch
Type: text/x-patch
Size: 128031 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200615/81aa727d/attachment-0001.bin>


More information about the llvm-commits mailing list