[PATCH] D81587: [MachineVerifier][GlobalISel] Check that branches have a MBB operand or are declared indirect. Add missing properties to G_BRJT, G_BRINDIRECT
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 15 07:01:01 PDT 2020
arsenm added inline comments.
================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:876
+
+ if (!HasMBB)
+ report("Branch instruction is missing a basic block operand or "
----------------
Braces
================
Comment at: llvm/test/MachineVerifier/test_g_brindirect_is_indirect_branch.mir:2
+# RUN: llc -march=riscv32 -o - -run-pass=none -verify-machineinstrs %s | FileCheck %s
+# REQUIRES: global-isel, riscv-registered-target
+
----------------
Don't need global-isel REQUIRES anymore
================
Comment at: llvm/test/MachineVerifier/test_g_brjt_is_indirect_branch.mir:2
+# RUN: llc -march=riscv32 -o - -run-pass=none -verify-machineinstrs %s | FileCheck %s
+# REQUIRES: global-isel, riscv-registered-target
+
----------------
Don't need global-isel REQUIRES anymore
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81587/new/
https://reviews.llvm.org/D81587
More information about the llvm-commits
mailing list