[PATCH] D81655: [yaml2obj] - Introduce the "NoHeaders" key for "SectionHeaderTable"

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Some mostly comment nits, otherwise LGTM.



================
Comment at: llvm/test/tools/yaml2obj/ELF/section-headers-exclude.yaml:80
+## Check that we are able to exclude all sections, except the implicit
+## null section with the use of the "Excluded" key.
+
----------------
section with -> section, with


================
Comment at: llvm/test/tools/yaml2obj/ELF/section-headers.yaml:82
 
-## Test that we are able to specify an empty sections list for
-## the "SectionHeaderTable" tag to produce no section header.
-# RUN: yaml2obj %s --docnum=2 -o %t3
+## Check that when the an empty "Sections" list is used, we do not create an empty section headers.
+# RUN: not yaml2obj %s --docnum=2 -o /dev/null 2>&1 | FileCheck %s --check-prefix=EMPTY-SECTIONS
----------------
an empty section header table.


================
Comment at: llvm/test/tools/yaml2obj/ELF/section-headers.yaml:86-87
+# EMPTY-SECTIONS: error: section '.foo' should be present in the 'Sections' or 'Excluded' lists
+# EMPTY-SECTIONS: error: section '.strtab' should be present in the 'Sections' or 'Excluded' lists
+# EMPTY-SECTIONS: error: section '.shstrtab' should be present in the 'Sections' or 'Excluded' lists
+
----------------
Can these be `-NEXT`?


================
Comment at: llvm/test/tools/yaml2obj/ELF/section-headers.yaml:101
+
+## Test that we are able to use "NoHeaders" property to produce no section header.
+# RUN: yaml2obj %s --docnum=3 -o %t3
----------------
section header -> an empty section header table

to match above comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81655/new/

https://reviews.llvm.org/D81655