[PATCH] D81375: [InstCombine] Simplify boolean Phis with const inputs using CFG
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 14 21:19:38 PDT 2020
mkazantsev planned changes to this revision.
mkazantsev marked an inline comment as done.
mkazantsev added a comment.
Some underlying transforms are missing it seems.
================
Comment at: llvm/test/Transforms/InstCombine/select.ll:512
; CHECK: ret:
-; CHECK-NEXT: [[P:%.*]] = phi i32 [ [[A:%.*]], [[JUMP]] ], [ [[B:%.*]], [[ENTRY:%.*]] ]
-; CHECK-NEXT: ret i32 [[P]]
+; CHECK-NEXT: [[C:%.*]] = phi i32 [ [[A:%.*]], [[JUMP]] ], [ [[B:%.*]], [[ENTRY:%.*]] ]
+; CHECK-NEXT: [[S:%.*]] = select i1 [[COND]], i32 [[A]], i32 [[C]]
----------------
xbolva00 wrote:
> Regressed
Because we are missing the respective transform for select. I can implement it first I guess...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81375/new/
https://reviews.llvm.org/D81375
More information about the llvm-commits
mailing list