[PATCH] D81375: [InstCombine] Simplify boolean Phis with const inputs using CFG

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 14 20:47:38 PDT 2020


xbolva00 added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/select.ll:512
 ; CHECK:       ret:
-; CHECK-NEXT:    [[P:%.*]] = phi i32 [ [[A:%.*]], [[JUMP]] ], [ [[B:%.*]], [[ENTRY:%.*]] ]
-; CHECK-NEXT:    ret i32 [[P]]
+; CHECK-NEXT:    [[C:%.*]] = phi i32 [ [[A:%.*]], [[JUMP]] ], [ [[B:%.*]], [[ENTRY:%.*]] ]
+; CHECK-NEXT:    [[S:%.*]] = select i1 [[COND]], i32 [[A]], i32 [[C]]
----------------
Regressed


================
Comment at: llvm/test/Transforms/PhaseOrdering/inlining-alignment-assumptions.ll:43
 ; ASSUMPTIONS-ON:       true1:
-; ASSUMPTIONS-ON-NEXT:    [[C_PR:%.*]] = phi i1 [ false, [[FALSE1]] ], [ true, [[TMP0:%.*]] ]
+; ASSUMPTIONS-ON-NEXT:    [[C_PR:%.*]] = phi i1 [ [[C]], [[FALSE1]] ], [ true, [[TMP0:%.*]] ]
 ; ASSUMPTIONS-ON-NEXT:    [[PTRINT:%.*]] = ptrtoint i64* [[PTR:%.*]] to i64
----------------
Unwanted


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81375/new/

https://reviews.llvm.org/D81375





More information about the llvm-commits mailing list