[PATCH] D81436: [AArch64][GlobalISel] Add G_EXT and select ext using it

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerCombiner.cpp:291
+  Register Dst = MI.getOperand(0).getReg();
+  auto ExtInfo = isEXTMask(MI.getOperand(3).getShuffleMask(),
+                           MRI.getType(Dst).getNumElements());
----------------
Tiny nit: if you're returning optional instead of bool unlike the DAG version, I think its better to name this getExtMask rather than isExtMask.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81436/new/

https://reviews.llvm.org/D81436