[PATCH] D81436: [AArch64][GlobalISel] Add G_EXT and select ext using it

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 11 18:43:32 PDT 2020


aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerCombiner.cpp:326
+  Register Cst = MRI.createGenericVirtualRegister(LLT::scalar(32));
+  MIRBuilder.buildConstant(Cst, MatchInfo.SrcOps[2].getImm());
+  MIRBuilder.buildInstr(MatchInfo.Opc, {MatchInfo.Dst},
----------------
You can just do:
`auto Cst = IRBuilder.buildConstant(LLT::scalar(32), MatchInfo.SrcOps[2].getImm());`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81436/new/

https://reviews.llvm.org/D81436





More information about the llvm-commits mailing list