[PATCH] D81165: [DebugInfo] Refactor how unrecoverable debug line parsing errors work

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I've spotted another example of where the current error handling technique doesn't work well combined with verbose output - when there is an error with the address size, the error will be reported mid line, which means that if the streams are interleaved, you'll get something like `0x0000002f: 00 DW_LNE_set_addresswarning: ... (0x00000008)`. There are potentially similar problems for other opcodes too. It could be possible to delay sending these errors to the handler until the  full line has been printed, but I'm not particularly happy with the code changes required for that. This further illustrates that making the verbose printing independent of the parsing somehow might be preferable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81165/new/

https://reviews.llvm.org/D81165