[PATCH] D81536: [VE] Support convert instructions in MC layer

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

Few nits.



================
Comment at: llvm/lib/Target/VE/VE.h:301
+  }
+  llvm_unreachable("Invalid branch predicates");
+  return VERD::UNKNOWN;
----------------
unreachable + return


================
Comment at: llvm/lib/Target/VE/VE.h:322
+  }
+  llvm_unreachable("Invalid branch predicates");
+  return VERD::UNKNOWN;
----------------
unreachable + return


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:406
+  let DecoderMethod = "DecodeRDOperand";
+//  let EncoderMethod = "getRDOpValue";
+  let ParserMatchClass = RDOpAsmOperand;
----------------
Is this commented out for future implementation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81536/new/

https://reviews.llvm.org/D81536