[PATCH] D81104: [XCOFF][AIX] report_fatal_error when an overflow section is needed

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.

LGTM with minor comments.



================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-huge-relocs.ll:8
+; RUN: not --crash llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff \
+; RUN:     -mcpu=pwr4 -mattr=-altivec -filetype=obj -o %t.o %t.overflow.ll 2>&1 | \
+; RUN:   FileCheck --check-prefix=OVERFLOW %s
----------------
Minor nit: Not sure if we want to align `-mcpu` with the `llc` options?


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-huge-relocs.ll:21
+; RUN: not --crash llc -verify-machineinstrs -mtriple powerpc64-ibm-aix-xcoff \
+; RUN:     -mcpu=pwr4 -mattr=-altivec -filetype=obj -o %t.o %t.overflow.ll 2>&1 | \
+; RUN:   FileCheck --check-prefix=XCOFF64 %s
----------------
Same comment.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-huge-relocs.ll:24
+; RUN: not --crash llc -verify-machineinstrs -mtriple powerpc64-ibm-aix-xcoff \
+; RUN:     -mcpu=pwr4 -mattr=-altivec -filetype=obj -o %t.o %t.ll 2>&1 | \
+; RUN:   FileCheck --check-prefix=XCOFF64 %s
----------------
Same comment.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-huge-relocs.ll:31
+
+; XCOFF32-NOT:     Name: .ovrflo
+; XCOFF32-NOT:     Type: STYP_OVRFLO
----------------
I think we'd need the `NOT` lines after the other lines as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81104/new/

https://reviews.llvm.org/D81104