[PATCH] D81104: [XCOFF][AIX] report_fatal_error when an overflow section is needed

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 08:11:23 PDT 2020


jasonliu marked an inline comment as done.
jasonliu added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:748
+          report_fatal_error(
+              "relocation entries overflowed; overflow section is "
+              "not implemented yet");
----------------
daltenty wrote:
> nit: Capitalization and period.
https://llvm.org/docs/CodingStandards.html#error-and-warning-messages
ask us not to capitalize first letter and end with period.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81104/new/

https://reviews.llvm.org/D81104





More information about the llvm-commits mailing list