[PATCH] D81301: [X86] Emit two-byte NOP when possible

Sat Jun 6 16:00:48 PDT 2020

cdavis5x added a comment.

> I'm a bit confused. Wine lists support up to Windows 10, which means recently-compiled applications should be supported. Meanning they (Wine) should see `66 90`, and support that. I asked the question anyway on the wine-devel mailing list.

No, I meant "they" as in "Windows programs that run on Wine." Older programs compiled before VS 2015 in particular are going to check for `8b ff` in functions from //the system's// DLLs. That's why Wine needed this from GCC and needs this from LLVM: so that functions in //its// DLLs have the signature so programs will know it's OK to hotpatch them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81301/new/

https://reviews.llvm.org/D81301