[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 269027.
fhahn marked 2 inline comments as done.
fhahn added a comment.

In D76794#2078232 <https://reviews.llvm.org/D76794#2078232>, @rjmccall wrote:

> Your IRGen test cases cover a lot of ground, but please add more Sema test cases that go over the basics: element types matching, column/row counts matching, multiplication by inappropriate scalars, etc.  Otherwise LGTM!


Oh, of course! I think some of those might have been accidentally dropped when moving patches around. I've added the additional Sema tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76794/new/

https://reviews.llvm.org/D76794

Files:
  clang/include/clang/Sema/Sema.h
  clang/lib/CodeGen/CGExprScalar.cpp
  clang/lib/Sema/SemaExpr.cpp
  clang/lib/Sema/SemaOverload.cpp
  clang/test/CodeGen/matrix-type-operators.c
  clang/test/CodeGenCXX/matrix-type-operators.cpp
  clang/test/Sema/matrix-type-operators.c
  clang/test/SemaCXX/matrix-type-operators.cpp
  llvm/include/llvm/IR/MatrixBuilder.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76794.269027.patch
Type: text/x-patch
Size: 27765 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200606/9d7fd616/attachment.bin>