[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

[John McCall via Phabricator via llvm-commits]

rjmccall added a comment.

Your IRGen test cases cover a lot of ground, but please add more Sema test cases that go over the basics: element types matching, column/row counts matching, multiplication by inappropriate scalars, etc.  Otherwise LGTM!



================
Comment at: clang/lib/Sema/SemaExpr.cpp:12130
+  QualType LHSType = LHS.get()->getType().getUnqualifiedType();
+  QualType RHSType = RHS.get()->getType().getUnqualifiedType();
+
----------------
You never actually do anything with these that cares about having gotten the unqualified type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76794/new/

https://reviews.llvm.org/D76794