[PATCH] D81238: Correctly report modified status for HWAddressSanitizer

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a reviewer: vitalybuka.
vitalybuka added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1088
 
   LLVM_DEBUG(dbgs() << "Function: " << F.getName() << "\n");
 
----------------
maybe do not bother with Changed and after this point always return true?


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1136
     // instrumented stack, so we can drop it.
     F.setPersonalityFn(nullptr);
   }
----------------
Changed = true?


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1164
     uint64_t AlignedSize = alignTo(Size, Mapping.getObjectAlignment());
     AI->setAlignment(
         Align(std::max(AI->getAlignment(), Mapping.getObjectAlignment())));
----------------
here and two ifs below?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81238/new/

https://reviews.llvm.org/D81238