[PATCH] D81238: Correctly report modified status for HWAddressSanitizer

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:919
     LocalDynamicShadow = getDynamicShadowNonTls(IRB);
-    return;
+    return false;
   }
----------------
I don't understand this `false`. getDynamicShadowNonTls creates IR (unless it returns nullptr).


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:924
     LocalDynamicShadow = getDynamicShadowIfunc(IRB);
-    return;
+    return false;
   }
----------------
Likewise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81238/new/

https://reviews.llvm.org/D81238