[PATCH] D81097: [llvm-objcopy] Reorder --dump-section before --remove-section for ELF. Fixes PR44283

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 3 10:58:32 PDT 2020


smeenai added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:274
+  if (Error E =
+          DWOFile->removeSections(Config.AllowBrokenLinks, OnlyKeepDWOPred))
     return E;
----------------
sameerarora101 wrote:
> Added by the linter!
I'd probably undo this change, given that this part of the code isn't close to the part of the code you're modifying.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81097/new/

https://reviews.llvm.org/D81097





More information about the llvm-commits mailing list