[PATCH] D81097: [llvm-objcopy] Reorder --dump-section before --remove-section for ELF. Fixes PR44283

[Sameer Arora via Phabricator via llvm-commits]

sameerarora101 created this revision.
sameerarora101 added reviewers: alexshap, jhenderson, Ktwu, smeenai.
Herald added subscribers: llvm-commits, abrachet, MaskRay, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: rupprecht.
Herald added a project: LLVM.
sameerarora101 marked an inline comment as done.
sameerarora101 added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:274
+  if (Error E =
+          DWOFile->removeSections(Config.AllowBrokenLinks, OnlyKeepDWOPred))
     return E;
----------------
Added by the linter!


Reorder `DumpSection` under `handleArgs` in
file `ELFObjcopy.cpp`. `DumpSection` is placed
before `replaceAndRemoveSections` and is therefore
now the first operation under `handleArgs`. Thus,
it is now performed before both `add` and `remove`
section operations.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81097

Files:
  llvm/test/tools/llvm-objcopy/ELF/dump-before-add-remove.test
  llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81097.268198.patch
Type: text/x-patch
Size: 3759 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200603/6dbd5ea8/attachment.bin>