[PATCH] D80916: [LegacyPM] Double check that passes correctly set their Modified status

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D80916#2071584 <https://reviews.llvm.org/D80916#2071584>, @serge-sans-paille wrote:

> The code is ostly borrowed from the transform utils. We can't have Core depend on Transform, but it's 100% possible to moe them around. I'll do that and update the patch.


I'm not sure it makes sense to share this code. The hashing in the transform utils is used for function merging, and as such is intentionally rather weak (in the sense that it will let many functions that are different hash to the same value, as the notion of equality in that pass is not that strict). This code on the other hand could hash in more information, to catch more possible issues. (It doesn't have to, but it wouldn't be incorrect to do so.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80916/new/

https://reviews.llvm.org/D80916