[PATCH] D80916: [LegacyPM] Double check that passes correctly set their Modified status

[serge via Phabricator via llvm-commits]

serge-sans-paille added a comment.

In D80916#2071583 <https://reviews.llvm.org/D80916#2071583>, @foad wrote:

> I like this and it is certainly useful for finding bugs. I'd like to see it for Loop, Region and SCC passes too. But I don't know if it's fast and/or robust enough to commit and have it enabled as-is.


It currently finds a bunch of bugs (passes not correctly reporting modification), I'm trying to fix them iteratively :-)

> Is there any other code for hashing Functions and Modules that we could use here instead of rolling our own?

The code is ostly borrowed from the transform utils. We can't have Core depend on Transform, but it's 100% possible to moe them around. I'll do that and update the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80916/new/

https://reviews.llvm.org/D80916