[PATCH] D81056: [Support] Replace 'DisableColors' boolean with 'ColorMode' enum

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D81056#2070328 <https://reviews.llvm.org/D81056#2070328>, @jhenderson wrote:

> Seems reasonable. Should there be some kind of unit-testing involved?


It is a good idea. WithColor does not have unit tests yet (`llvm/unittests/Support/WithColorTest.cpp`)

> It might be nice (not now but in the future) to change the interface of the `WithColor` constructors, to change the `DisableColors` boolean into the `ColorMode` enum too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81056/new/

https://reviews.llvm.org/D81056