[PATCH] D81056: [Support] Replace 'DisableColors' boolean with 'ColorMode' enum
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 3 00:30:54 PDT 2020
jhenderson added a comment.
Seems reasonable. Should there be some kind of unit-testing involved?
It might be nice (not now but in the future) to change the interface of the `WithColor` constructors, to change the `DisableColors` boolean into the `ColorMode` enum too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81056/new/
https://reviews.llvm.org/D81056
More information about the llvm-commits
mailing list