[PATCH] D80862: [ObjectYAML][test] Address comments in D80203

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 03:09:48 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM, but best wait for @MaskRay to clarify what he means.



================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-str.yaml:18
 
-#                Name       Type     Address          Offset Size   ES Flg Lk Inf Al
+##               Name       Type     Address          Offset Size   ES Flg Lk Inf Al
 # SHDRS-DEFAULT: .debug_str PROGBITS 0000000000000000 000040 000006 01 MS  0  0   1
----------------
MaskRay wrote:
> I think you can just make this a `SHDRS:` check line. The cost is negligible.
I'm not quite sure I follow @MaskRay?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80862/new/

https://reviews.llvm.org/D80862





More information about the llvm-commits mailing list