[PATCH] D80203: [ObjectYAML][DWARF] Add DWARF entry in ELFYAML.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 03:09:48 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-str.yaml:145
+    Offset:       0x00000050         # 0x40 for the first section.
+    Size:         6                  # Set the "Size" so that we can reuse the check tag "OVERRIEDDEN"
+
----------------
Higuoxing wrote:
> jhenderson wrote:
> > jhenderson wrote:
> > > There's a typo: OVERRIEDDEN -> OVERRIDDEN
> > It looks like this comment wasn't addressed?
> Should be fixed in D80802. Sorry I didn't notice it here.
For posterity:
D80802 -> D80862


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80203/new/

https://reviews.llvm.org/D80203





More information about the llvm-commits mailing list