[PATCH] D80874: [llvm-dwarfdump] Add a table header for -debug-line -verbose output

Mon Jun 1 03:09:47 PDT 2020

ikudrin added inline comments.

================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:706
+    *OS << '\n';
+    Row::dumpTableHeader(*OS, 12);
   }
----------------
jhenderson wrote:
> Will 12 be the right number if using DWARF64 (i.e. with 64-bit section offsets)?
> 
> (probably not, but maybe okay for now with a FIXME/TODO for DWARF64, as it looks like we aren't currently printing the offsets as fixed width for DWARF64).
I'd prefer to keep the current convention of printing offsets. They are not something that has a real size in the file, like fields that we started printing with extended widths in D79997. They are just positions in sections and in most cases they will not exceed 4G boundary, even for the DWARF64 case. Printing all offsets in a unified way makes the report tidier.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80874/new/

https://reviews.llvm.org/D80874