[PATCH] D80874: [llvm-dwarfdump] Add a table header for -debug-line -verbose output

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Column headers probably make some sense. This might clash with my ongoing patches in the area, but I think that's okay - we can both adapt patches as needed without any real dififculty. You should probably update the primary verbose test (i.e. `verbose.test`) rather than (or possibly in addition to) the test you have modified though. If you do it in addition, you probably don't need the --strict-whitespace/--match-full-lines options in the `debug-line-dw-lne-end-sequence.s` test.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:706
+    *OS << '\n';
+    Row::dumpTableHeader(*OS, 12);
   }
----------------
Will 12 be the right number if using DWARF64 (i.e. with 64-bit section offsets)?

(probably not, but maybe okay for now with a FIXME/TODO for DWARF64, as it looks like we aren't currently printing the offsets as fixed width for DWARF64).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80874/new/

https://reviews.llvm.org/D80874