[PATCH] D78459: [AVR] Don't adjust for instruction size

Dylan McKay via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 31 04:47:14 PDT 2020


dylanmckay added a comment.

> Are you planning on adding these integration tests to the LLVM buildbot or something more manual?

At the moment, it's something more manual, but I'm working on having it automated.

I don't think it is tenable to add the AVR simulator integration tests to the LLVM buildbot, but I haven't asked llvm-dev yet. I remember reading a thread on llvm-dev fairly recently for a similar problem where a developer wanted to add automated checks to all LLVM changes. It was suggested to integrate the tests into Phabricator rather than the buildbot, perhaps this is something AVR can do. In that thread, a Google project that adds some "Pre-merge checks" (also included on this differential) to Phabricator was suggested as a good starting point. There may be considerations due to the progressive move towards LLVM enabling GitHub features on its repositories over time.

> Eventually, we might be able to run the GCC torture test suite to find the remaining bugs.

I haven't looked into GCC torture suite, I wasn't aware we could run with non-GNU compilers like Clang but that makes sense. This would be very interesting to run it for AVR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78459/new/

https://reviews.llvm.org/D78459





More information about the llvm-commits mailing list