[PATCH] D78459: [AVR] Don't adjust for instruction size

Sat May 30 19:05:59 PDT 2020

dylanmckay added inline comments.

================
Comment at: llvm/lib/Target/AVR/MCTargetDesc/AVRAsmBackend.cpp:92

-  Value -= 2;
-
----------------
Copy-paste your `avr-jmp.c` test into `llvm-project/clang/test/CodeGen/avr`

https://gist.github.com/aykevl/d23d91a39589f5b4abc13b3dd0b304c4

Add `CHECK` lines for the new disassembly output

```
 802:	0e 94 00 00 	call	0	; 0x0 <foo>
			802: R_AVR_CALL	bar
 806:	0c 94 00 00 	jmp	0	; 0x0 <foo>
			806: R_AVR_CALL	.text
```

I'm going to add your `avr-jmp.c` test into the integration test suite as well. I intend to set up a build status page for it soon.

Really good patch. You may be right about the misreading of the `CALL` machine specification - good catch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78459/new/

https://reviews.llvm.org/D78459