[PATCH] D80838: [llvm-ar] Add more tests for errors in opening archives

[Sameer Arora via Phabricator via llvm-commits]

sameerarora101 created this revision.
Herald added subscribers: llvm-commits, rupprecht, MaskRay.
Herald added a project: LLVM.
sameerarora101 added reviewers: alexshap, jhenderson, Ktwu, smeenai.

Add 2 more tests for the function
performOperation under llvm-ar.cpp. It tests
the scenario when the archive could not be opened
for reasons other than `no_such_file_or_directory`
In particular, it tests for the cases `permission_denied`
 and `is_a_directory` for the target archive.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80838

Files:
  llvm/test/tools/llvm-ar/print.test


Index: llvm/test/tools/llvm-ar/print.test
===================================================================
--- llvm/test/tools/llvm-ar/print.test
+++ llvm/test/tools/llvm-ar/print.test
@@ -68,7 +68,7 @@
 ## No archive:
 # RUN: not llvm-ar p 2>&1 \
 # RUN:   | FileCheck %s --check-prefix=NO-ARCHIVE
-# 
+#
 # NO-ARCHIVE: error: an archive name must be specified
 
 ## Archive does not exist:
@@ -77,6 +77,21 @@
 
 # MISSING-ARCHIVE: error: error loading '[[ARCHIVE]]': {{[nN]}}o such file or directory
 
+## No Permission
+# RUN: llvm-ar -rc %t/permission.b %t/1.txt
+# RUN: chmod 100 %t/permission.b
+# RUN: not llvm-ar p %t/permission.b 2>&1 \
+# RUN:   | FileCheck %s --check-prefix=NO-PERMISSION -DARCHIVE=%t/permission.b
+
+# NO-PERMISSION: error: error opening '[[ARCHIVE]]': Permission denied
+
+## Passing in a directory
+# RUN: mkdir -p %t/tmpDir
+# RUN: not llvm-ar p %t/tmpDir 2>&1 \
+# RUN:    | FileCheck %s --check-prefix=IS-DIR -DARCHIVE=%t/tmpDir
+
+# IS-DIR: error: error opening '[[ARCHIVE]]': Is a directory
+
 ## Member does not exist:
 # RUN: not llvm-ar p %t/archive.a %t-missing.txt 2>&1 \
 # RUN:   | FileCheck %s --check-prefix=MISSING-FILE -DFILE=%t-missing.txt


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80838.267363.patch
Type: text/x-patch
Size: 1191 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200529/c9c5f0a7/attachment.bin>