[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 14:14:26 PDT 2020


jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:376
+  /// generation.
+  llvm::OpenMPIRBuilder InternalOMPBuilder;
 
----------------
jhuber6 wrote:
> Should D80222 be changed to use this instead and remove the static methods?
Good catch! Please copy this into D80222, use it instead of making the methods static, and commit the entire thing. For this change static is no option so it makes sense to just use it all over :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80735/new/

https://reviews.llvm.org/D80735





More information about the llvm-commits mailing list