[PATCH] D80635: [llvm-readobj][test] - unwind.test: add comments, document the current behavior.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 03:13:35 PDT 2020


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/unwind.test:208
     AddressAlign:    8
     Content:         1400000000000000017A5200017810011B0C070890010710140000001C000000B0F0FFFF2A00000000000000000000001400000000000000017A5200017810011B0C070890010000240000001C00000050F0FFFF20000000000E10460E184A0F0B770880003F1A3B2A332422000000001C000000440000003EF1FFFF1000000000410E108602430D064B0C07080000002C0000006400000038F1FFFF7F0C000000450C0A00491006027600450F0376780603660C0C0A00450C070800000000002C0000009400000088FDFFFF6600000000410E108602430D06428F03458E04478D058C06488307024B0C07080000000014000000C4000000C8FDFFFF01000000000000000000000000000000
 Symbols:
----------------
jhenderson wrote:
> Not related to this change, but yuck, this is horrible. Probably this wants implementing in yaml2obj at some point (perhaps wait until @Higuoxing has done work on .debug_frame support though). Same sort of comment applies ot the content of the .eh_frame_hdr though.
Perhaps it worth to implement `ContentArray` for such temporarily tests, like we discussed before in D75123.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80635/new/

https://reviews.llvm.org/D80635





More information about the llvm-commits mailing list