[PATCH] D80635: [llvm-readobj][test] - unwind.test: add comments, document the current behavior.

Fri May 29 02:08:34 PDT 2020

jhenderson accepted this revision.
jhenderson added a subscriber: Higuoxing.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with comment suggestions.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/unwind.test:208
     AddressAlign:    8
     Content:         1400000000000000017A5200017810011B0C070890010710140000001C000000B0F0FFFF2A00000000000000000000001400000000000000017A5200017810011B0C070890010000240000001C00000050F0FFFF20000000000E10460E184A0F0B770880003F1A3B2A332422000000001C000000440000003EF1FFFF1000000000410E108602430D064B0C07080000002C0000006400000038F1FFFF7F0C000000450C0A00491006027600450F0376780603660C0C0A00450C070800000000002C0000009400000088FDFFFF6600000000410E108602430D06428F03458E04478D058C06488307024B0C07080000000014000000C4000000C8FDFFFF01000000000000000000000000000000
 Symbols:
----------------
Not related to this change, but yuck, this is horrible. Probably this wants implementing in yaml2obj at some point (perhaps wait until @Higuoxing has done work on .debug_frame support though). Same sort of comment applies ot the content of the .eh_frame_hdr though.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/unwind.test:241
+
+## Check we dump the unwind information partially when the PT_GNU_EH_FRAME segment points to a truncated data.
+# RUN: yaml2obj --docnum=1 %s -DMEMSIZE=0x1 -DFILESIZE=0x1 -o %t1.truncated
----------------
we partially dump the unwind information when

to a truncated -> to truncated

The line probably wants splitting in two.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80635/new/

https://reviews.llvm.org/D80635