[PATCH] D79890: [MLIR] Continue renaming of "SideEffects"

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 27 23:24:55 PDT 2020


mehdi_amini added a comment.

In D79890#2059096 <https://reviews.llvm.org/D79890#2059096>, @stephenneuendorffer wrote:

> @mehdi_amini @rriddle  There were multiple commenters who thought it was better to be consistent even if there was further mass renaming involved:
>  see https://reviews.llvm.org/D79517


Sure but my assumption is that the mass renaming is coming... Otherwise I'd have push back here.
(But I actually didn't understand why "being consistent" was preventing from renaming in the other direction in the first place....)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79890/new/

https://reviews.llvm.org/D79890





More information about the llvm-commits mailing list