[PATCH] D79717: [MLIR] Add shape.witness type and ops

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td:358
+    Example:
+    ```mlir
+      %s0 = shape.any([2,?], [?,3]) // [2,3]
----------------
nit: newline before the code sample.


================
Comment at: mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td:459
+
+// Canonicalization patterns.
+
----------------
Can we remove this?


================
Comment at: mlir/lib/Dialect/Shape/IR/Shape.cpp:54
 
   if (keyword == "component")
     return ComponentType::get(getContext());
----------------
Seems like this should move to using StringSwitch at this point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79717/new/

https://reviews.llvm.org/D79717